Remove MASP pin key #3142
Remove MASP pin key #3142
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
==========================================
+ Coverage 59.41% 59.62% +0.21%
==========================================
Files 298 298
Lines 92326 91988 -338
==========================================
- Hits 54853 54851 -2
+ Misses 37473 37137 -336 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/remove-pin-key
branch
from
8e3bc95
to
b3fff8d
Compare
|
|
|
@yito88 do you think this error could be due to Hermes? |
|
@grarco yes, Hermes makes a request for a shielded transfer now. |
|
I tried to update Hermes with this branch: https://github.com/heliaxdev/hermes/tree/1.7.4-namada-3142 |
* grarco/remove-pin-key: Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
| @@ -621,8 +621,5 @@ impl ArgFromMutContext for BalanceOwner { | |||
| ExtendedViewingKey::arg_from_mut_ctx(ctx, raw) | |||
| .map(Self::FullViewingKey) | |||
| }) | |||
| .or_else(|_| { | |||
There was a problem hiding this comment.
I believe it was only used for the pinned balance
* origin/grarco/remove-pin-key: Removes `query_tx_deltas` Changelog #2675 Removes unused errors and integration test Fixes econding. Updates shielded keys and addresses for tests Adjusts wasm txs and client args Removes masp pin key Rmoves old allowlisted gas
Describe your changes
Closes #2675.
Closes #2381.
Removes the MASP pin key and the associated data/methods. Recomputes the shielded keys and addresses for tests given the changes in the encoding. Removes
query_tx_deltasas it is unused now.Indicate on which release or other PRs this topic is based on
v0.34.0
Checklist before merging to
draft