-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systems crate #3472
systems crate #3472
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
==========================================
- Coverage 54.51% 54.51% -0.01%
==========================================
Files 323 323
Lines 113288 113277 -11
==========================================
- Hits 61762 61751 -11
Misses 51526 51526 ☔ View full report in Codecov by Sentry. |
0e1db34
to
496b964
Compare
e19acd3
to
3793519
Compare
3793519
to
105183a
Compare
105183a
to
b9a1d0c
Compare
b9a1d0c
to
48149ca
Compare
48149ca
to
a4e50d7
Compare
@Mergifyio refresh |
✅ Pull request refreshed |
@tzemanovic @Fraccaman the changelog ci job is failing for some reason |
it should be fixed from #3559 but the base of this PR doesn't have this included |
☑️ Nothing to do
|
a4e50d7
to
c64c7aa
Compare
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
Describe your changes
Adding a new systems crate to contain the abstract interfaces, previously added to core crate in the base PR. Also switched to use the concrete storage error and result type instead of the generic associated type which reduces the amount of typing needed one the caller side.
Updated dep graph
Indicate on which release or other PRs this topic is based on
Depends-On: #3402
Checklist before merging to
draft