Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant build_pow_flag function. #3502

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jul 10, 2024

Describe your changes

Removed redundant build_pow_flag function.

Indicate on which release or other PRs this topic is based on

Namada v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@murisi murisi marked this pull request as ready for review July 10, 2024 11:30
@murisi murisi requested a review from brentstone July 10, 2024 11:30
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.48%. Comparing base (8479d38) to head (4f68c06).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3502      +/-   ##
==========================================
- Coverage   53.48%   53.48%   -0.01%     
==========================================
  Files         320      320              
  Lines      110000   109984      -16     
==========================================
- Hits        58832    58820      -12     
+ Misses      51168    51164       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman mentioned this pull request Jul 16, 2024
brentstone
brentstone previously approved these changes Jul 16, 2024
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just add a changelog?

brentstone added a commit that referenced this pull request Jul 17, 2024
* murisi/without-pow:
  changelog: add #3502
  Removed redundant build_pow_flag function.
@brentstone brentstone merged commit 3c1206c into main Jul 24, 2024
15 of 19 checks passed
@brentstone brentstone deleted the murisi/without-pow branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants