-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/decode asset types #3507
Conversation
d5f3fc2
to
d1b14e3
Compare
d1b14e3
to
ec20477
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3507 +/- ##
==========================================
- Coverage 61.18% 61.16% -0.02%
==========================================
Files 311 311
Lines 101433 101464 +31
==========================================
Hits 62059 62059
- Misses 39374 39405 +31 ☔ View full report in Codecov by Sentry. |
…saction printers.
d4927aa
to
704af7a
Compare
@Mergifyio refresh |
✅ Pull request refreshed |
Hey @murisi, your pull request has been dequeued due to the following reason: PR_DEQUEUED. |
@Mergifyio requeue |
☑️ This pull request is already queued |
Hey @murisi, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Hey @murisi, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
@Mergifyio dequeue |
✅ The pull request has been removed from the queue
|
@mergify requeue |
Hey @murisi, your pull request has been dequeued due to the following reason: PR_DEQUEUED. |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Describe your changes
This PR makes miscellaneous improvements to the test vector generator:
Transaction
test vector is rendered as anAssetType
even when it can and should be decoded into anAddress
. This PR fixes that.The corresponding changes to the Ledger app are at Zondax/ledger-namada#58 .
Indicate on which release or other PRs this topic is based on
Namada 0.41.0
Checklist before merging to
draft