Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fee tracing message #3547

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Improve fee tracing message #3547

merged 2 commits into from
Jul 31, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Jul 24, 2024

Describe your changes

Improves the trace error message in case of a failed masp fee payment.

Indicate on which release or other PRs this topic is based on

v0.41.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco changed the title Fix misleading tracing message Improve fee tracing message Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (f979859) to head (fb60b10).
Report is 8 commits behind head on main.

Files Patch % Lines
crates/node/src/protocol.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   54.55%   54.54%   -0.01%     
==========================================
  Files         324      324              
  Lines      113438   113439       +1     
==========================================
- Hits        61882    61874       -8     
- Misses      51556    51565       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco added a commit that referenced this pull request Jul 24, 2024
@grarco grarco marked this pull request as ready for review July 24, 2024 18:35
@grarco grarco requested a review from brentstone July 24, 2024 18:35
@brentstone brentstone mentioned this pull request Jul 24, 2024
grarco added a commit that referenced this pull request Jul 25, 2024
@Fraccaman Fraccaman added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass and removed ready for draft labels Jul 31, 2024
@Fraccaman Fraccaman self-requested a review July 31, 2024 16:18
mergify bot added a commit that referenced this pull request Jul 31, 2024
@mergify mergify bot merged commit d8abc13 into main Jul 31, 2024
20 of 21 checks passed
@mergify mergify bot deleted the grarco/fix-fee-log-msg branch July 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants