Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shielded sync phase 3 client #3578

Merged
merged 58 commits into from
Aug 16, 2024
Merged

Shielded sync phase 3 client #3578

merged 58 commits into from
Aug 16, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Aug 1, 2024

Describe your changes

Closes #3385

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 65.76223% with 959 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (c7520ac) to head (9626233).
Report is 103 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp/shielded_sync/utils.rs 37.83% 511 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 238 Missing ⚠️
crates/sdk/src/masp/shielded_sync/dispatcher.rs 89.63% 116 Missing ⚠️
crates/core/src/control_flow/mod.rs 14.63% 35 Missing ⚠️
crates/sdk/src/io.rs 31.81% 15 Missing ⚠️
crates/tx/src/types.rs 69.76% 13 Missing ⚠️
crates/sdk/src/masp.rs 88.77% 11 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 6 Missing ⚠️
crates/node/src/shell/testing/node.rs 0.00% 3 Missing ⚠️
crates/sdk/src/wallet/keys.rs 25.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
+ Coverage   61.22%   61.25%   +0.03%     
==========================================
  Files         312      315       +3     
  Lines      101609   102808    +1199     
==========================================
+ Hits        62209    62976     +767     
- Misses      39400    39832     +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@batconjurer batconjurer force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from 0861131 to 239c6d0 Compare August 2, 2024 09:40
@sug0 sug0 force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from 1b07ee6 to 939d3ba Compare August 13, 2024 14:31
@sug0 sug0 marked this pull request as ready for review August 13, 2024 14:31
sug0 added a commit that referenced this pull request Aug 13, 2024
@sug0 sug0 force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from 939d3ba to def6bc5 Compare August 13, 2024 14:48
sug0 added a commit that referenced this pull request Aug 13, 2024
@sug0 sug0 force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from def6bc5 to 1b1c3bc Compare August 13, 2024 14:52
@sug0
Copy link
Contributor Author

sug0 commented Aug 13, 2024

We might need to point flume to zesterer/flume#138

Otherwise, the usage of this code in web browser wasm environments might be compromised.

sug0 added a commit that referenced this pull request Aug 14, 2024
@sug0 sug0 force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from 1b1c3bc to 66eebf0 Compare August 14, 2024 08:38
@sug0 sug0 force-pushed the tiago+jacob/masp-ss-client-phase-3 branch from 66eebf0 to b689533 Compare August 14, 2024 14:40
@Fraccaman
Copy link
Member

whats the status here?

@tzemanovic
Copy link
Member

whats the status here?

we need 1 more review on this

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 16, 2024
mergify bot added a commit that referenced this pull request Aug 16, 2024
@mergify mergify bot merged commit 7e9239d into main Aug 16, 2024
18 of 19 checks passed
@mergify mergify bot deleted the tiago+jacob/masp-ss-client-phase-3 branch August 16, 2024 15:26
@sug0 sug0 mentioned this pull request Aug 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shielded sync refactor
5 participants