Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check masp action #3632

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Check masp action #3632

merged 3 commits into from
Aug 15, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Aug 13, 2024

Describe your changes

Changes get_masp_section_ref to return an error if more than one MASP action is found (MASP VP doesn't handle multiple Transaction objects).
Also adjusts the logic, in case of an error propagation from tx execution, to prevent committing the changes applied by the failed tx.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 24 lines in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (511f079) to head (abd4692).
Report is 56 commits behind head on main.

Files Patch % Lines
crates/node/src/protocol.rs 42.10% 11 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 8 Missing ⚠️
crates/tx/src/action.rs 68.75% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   61.27%   61.27%           
=======================================
  Files         312      312           
  Lines      101338   101369   +31     
=======================================
+ Hits        62092    62111   +19     
- Misses      39246    39258   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review August 13, 2024 15:14
@grarco grarco requested a review from tzemanovic August 14, 2024 15:45
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 15, 2024
mergify bot added a commit that referenced this pull request Aug 15, 2024
@mergify mergify bot merged commit 80268fa into main Aug 15, 2024
21 of 32 checks passed
@mergify mergify bot deleted the grarco/check-masp-action branch August 15, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants