Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates refactors #3670

Merged
merged 38 commits into from
Aug 27, 2024
Merged

crates refactors #3670

merged 38 commits into from
Aug 27, 2024

Conversation

tzemanovic
Copy link
Member

Describe your changes

closes #2111

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 59.69828% with 748 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (15ac38c) to head (c71daae).
Report is 70 commits behind head on main.

Files Patch % Lines
crates/node/src/protocol.rs 50.26% 93 Missing ⚠️
crates/governance/src/vp/mod.rs 30.08% 79 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 66 Missing ⚠️
crates/proof_of_stake/src/vp.rs 0.00% 46 Missing ⚠️
crates/core/src/chain.rs 88.26% 44 Missing ⚠️
crates/core/src/parameters.rs 60.18% 43 Missing ⚠️
crates/vm/src/host_env.rs 73.39% 29 Missing ⚠️
crates/vp_prelude/src/lib.rs 41.66% 28 Missing ⚠️
crates/storage/src/error.rs 27.02% 27 Missing ⚠️
crates/vp/src/native_vp.rs 49.05% 27 Missing ⚠️
... and 50 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3670      +/-   ##
==========================================
+ Coverage   61.17%   61.23%   +0.05%     
==========================================
  Files         315      315              
  Lines      103187   102840     -347     
==========================================
- Hits        63125    62970     -155     
+ Misses      40062    39870     -192     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review August 23, 2024 11:42
tzemanovic added a commit that referenced this pull request Aug 23, 2024
@tzemanovic tzemanovic changed the title crate refactors crates refactors Aug 23, 2024
tzemanovic added a commit that referenced this pull request Aug 23, 2024
@Fraccaman
Copy link
Member

im not sure but do u mind checking if some of the paths in codecov.yml have changed?

@tzemanovic
Copy link
Member Author

im not sure but do u mind checking if some of the paths in codecov.yml have changed?

not that I can see, why?

crates/core/src/chain.rs Outdated Show resolved Hide resolved
crates/core/src/chain.rs Outdated Show resolved Hide resolved
crates/core/src/chain.rs Outdated Show resolved Hide resolved
crates/core/src/chain.rs Outdated Show resolved Hide resolved
crates/core/src/chain.rs Outdated Show resolved Hide resolved
crates/node/src/protocol.rs Show resolved Hide resolved
crates/node/src/protocol.rs Outdated Show resolved Hide resolved
tzemanovic and others added 2 commits August 27, 2024 15:43
@sug0 sug0 self-requested a review August 27, 2024 14:03
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 27, 2024
mergify bot added a commit that referenced this pull request Aug 27, 2024
mergify bot added a commit that referenced this pull request Aug 27, 2024
@mergify mergify bot merged commit aefa330 into main Aug 27, 2024
21 of 22 checks passed
@mergify mergify bot deleted the tomas/crate-refactors branch August 27, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure codebase for a module-based separation of concerns
3 participants