Minor fixes to governance cli/msgs #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
approved these changes
Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3689 +/- ##
==========================================
- Coverage 61.19% 61.18% -0.01%
==========================================
Files 315 315
Lines 103164 103187 +23
==========================================
+ Hits 63135 63139 +4
- Misses 40029 40048 +19 ☔ View full report in Codecov by Sentry. |
Fraccaman
approved these changes
Aug 23, 2024
Fraccaman
added
the
merge
Fraccaman
added a commit
that referenced
this pull request
Aug 26, 2024
…dump * origin/main: (191 commits) ci: use custom runner for docs step fix: better checkout settings, fix sccache wrapper changelog: add #3694 fix wasm dir during join-network Changelog #3689 Minor fixes to governance cli/msgs fix: use current epoch Changelog Add script boot localnet with two genesis validators Updates expected msg in wallet e2e test Changelog #3681 Two attempts for decryption password Removes comments Prompts the key that we are trying to decrypt Terminates client if decryption of signing key fails Propagates error in sdk if decryption of signing key fails Removes FIXME comment Add fullnode support added changelog token: fix transfer to self make build: exclude fuzz targets replace context with client Changelog #3676 Removes test step from wasm for test Makefile Removes dev dependencies from wasm tests Amend comment in genesis sign txs Changelog #3669 Updates help message of `--gas-limit` Refactors `dispatch_inner_txs` Adds masp fee payment integration test Improves safety of masp txs events fix for clippy is_apple_silicon fixup! ci: add job checking for cargo docs README: update docs section fix rustdoc issues ci: do not run changelog check on rc branches ci: increase integration tests timeout ci: add job checking for cargo docs Namada 0.43.0 generate key changelog: add #3445 fuzz: add txs_wasm_run fuzz: add txs_finalize_block target add conditional fuzzing sig acceptance at lower level fuzz: add txs_process_proposal fuzz: add README.md token: avoid trying to read denom when fuzzing prepare_proposal: make tx fee checks pass for fuzzing fuzz: add txs_prepare_proposal fuzz: use a shorter target name fix clippy tx: prevent overflow in arbitrary masp builder fuzz_txs_mempool: rm unused import impl Arbitrary for MaspBuilder to derive tx sections use updated jubjub that prevents invalid arb ExtendedPoint fuzz_txs_mempool: catch panics in serialization fuzz_txs_mempool: use non-panicking tx serialization method tx: add non-panicking serialization method tx: add arbitrary masp tx section make/fuzz-txs-mempool: run with `--dev` to avoid OOM shell/mempool: skip chain ID check for fuzzing tx: fix manual impl Arbitrary for Section core/key: fix arbitrary impls fuzz_txs_mempool: re-use TestShell between runs fuzz: set dev opt-level = 3 node/init_chain: no wasm pre-compile for fuzzing Makefile: add `cargo-fuzz` dep and `fuzz-txs-mempool` recipe fuzz mempool with arb txs tx: impl Arbitrary for Tx init a fuzz target with cargo-fuzz fixup! test/e2e/ledger: add test-genesis `--check-can-sign` args Improves failures handling in `try_masp_fee_payment` Matches masp ref order in protocol with that of the masp vp changelog: add #3660 test/e2e/ledger: add test-genesis `--check-can-sign` args cli: added `--check-can-sign` arg to `namadan utils test-genesis` add changelog rm accidentally revived files test/e2e/ledger_tests: add localnet genesis test using `utils test-genesis` fix to check the existing addr fix default refund target fix tests add shielded mode to transfer context change to transparent addr Added changelog Fixed bug in creating BenchShieldedContext Changelog for #3655 Optimize building chain ctx node/utils/test-genesis: remove unnecessary broadcaster task Added tests that birthdays work correctly with shielded sync changelog: add #3652 cli/client: fix clippy cli/node: don't load ctx for node utils Added dated keys to shielded sync args Removed birthday logic from payment address generation Moved type alias to a more logical location Changelog #3626 Changes gaia e2e tests to use masp internal address instead of payment addresses for ibc-shielding Reverts previous changes ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses some minor governance issues:
PROPOSAL_ETHcli arg--proposal-idarg was not shown in the help message ofproposal-voteChecklist before merging
breaking::labels