Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch reveal_pk #3720

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Batch reveal_pk #3720

merged 4 commits into from
Aug 29, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Aug 28, 2024

Describe your changes

Closes #1879.

When the client detects that an extra reveal_pk transaction is needed, instead of submitting it as a separate tx before the intended one, it now groups the two (or more) transactions together and submits them as a single batch.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@grarco grarco marked this pull request as ready for review August 29, 2024 10:04
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.03%. Comparing base (cc0a448) to head (3f8c058).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3720      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.02%     
==========================================
  Files         330      330              
  Lines      116209   116268      +59     
==========================================
+ Hits        79041    79106      +65     
+ Misses      37168    37162       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco requested review from Fraccaman and sug0 August 29, 2024 10:40
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 29, 2024
mergify bot added a commit that referenced this pull request Aug 29, 2024
@mergify mergify bot merged commit 15b6059 into main Aug 29, 2024
35 of 36 checks passed
@mergify mergify bot deleted the grarco/batch-reveal-pk branch August 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better gas handling for submit_reveal_aux
3 participants