Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build namadar #3752

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Don't build namadar #3752

merged 2 commits into from
Sep 5, 2024

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Just don't build it anymore, can easily incorporate back into namada_apps if we decide to use it in the future.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

brentstone added a commit that referenced this pull request Sep 4, 2024
@brentstone brentstone marked this pull request as ready for review September 4, 2024 20:59
@brentstone brentstone requested a review from sug0 September 4, 2024 20:59
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (c7f6a80) to head (fe0feae).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
+ Coverage   72.42%   72.43%   +0.01%     
==========================================
  Files         335      335              
  Lines      104005   104005              
==========================================
+ Hits        75322    75334      +12     
+ Misses      28683    28671      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/apps/src/bin/namada/cli.rs Outdated Show resolved Hide resolved
crates/apps/Cargo.toml Outdated Show resolved Hide resolved
brentstone added a commit that referenced this pull request Sep 5, 2024
@brentstone brentstone requested a review from sug0 September 5, 2024 09:00
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 5, 2024
@mergify mergify bot merged commit ac24f58 into main Sep 5, 2024
23 checks passed
@mergify mergify bot deleted the brent/dont-build-namadar branch September 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants