Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom tx error and help msg #3757

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Closes #3062.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

brentstone added a commit that referenced this pull request Sep 5, 2024
@brentstone brentstone marked this pull request as ready for review September 5, 2024 14:19
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (ef49b3d) to head (03c9cbf).

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3757      +/-   ##
==========================================
- Coverage   72.50%   72.49%   -0.01%     
==========================================
  Files         338      338              
  Lines      104190   104195       +5     
==========================================
  Hits        75541    75541              
- Misses      28649    28654       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @brentstone, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
@mergify mergify bot merged commit bd686dc into main Sep 6, 2024
22 of 23 checks passed
@mergify mergify bot deleted the brent/better-custom-tx-error branch September 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error message could be improved on custom wasm code execution
2 participants