-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix config from env var #3971
fix config from env var #3971
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3971 +/- ##
=======================================
Coverage 73.99% 74.00%
=======================================
Files 341 341
Lines 106614 106634 +20
=======================================
+ Hits 78888 78910 +22
+ Misses 27726 27724 -2 ☔ View full report in Codecov by Sentry. |
Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Describe your changes
fixes #3953
The config-rs prefix separator behavior had a regression introduced after 0.11 rust-cli/config-rs#291 where instead of the previous single underscore prefix separator it was using the field separator with double underscore. The fix was introduced in rust-cli/config-rs#292 that allows to specify prefix separator.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo