Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config from env var #3971

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix config from env var #3971

merged 4 commits into from
Nov 5, 2024

Conversation

tzemanovic
Copy link
Member

Describe your changes

fixes #3953

The config-rs prefix separator behavior had a regression introduced after 0.11 rust-cli/config-rs#291 where instead of the previous single underscore prefix separator it was using the field separator with double underscore. The fix was introduced in rust-cli/config-rs#292 that allows to specify prefix separator.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from brentstone November 4, 2024 14:03
tzemanovic added a commit that referenced this pull request Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (a148ac3) to head (b51078f).
Report is 50 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3971   +/-   ##
=======================================
  Coverage   73.99%   74.00%           
=======================================
  Files         341      341           
  Lines      106614   106634   +20     
=======================================
+ Hits        78888    78910   +22     
+ Misses      27726    27724    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 4, 2024
mergify bot added a commit that referenced this pull request Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member Author

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Nov 5, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Nov 5, 2024
@mergify mergify bot merged commit 5202e05 into main Nov 5, 2024
24 checks passed
@mergify mergify bot deleted the tomas/fix-config-from-env branch November 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overriding Configs with Environment Variables Not Working
2 participants