Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid updating merkle paths of spent notes #4018

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Nov 13, 2024

Describe your changes

Avoid updating merkle paths of spent notes. This should optimize the synchronous path of the shielded sync on the ledger client.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

sug0 added a commit that referenced this pull request Nov 13, 2024
@sug0 sug0 force-pushed the tiago/update-witness-map-on-spend branch from 3325b92 to 550e03a Compare November 13, 2024 13:51
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (b2332bf) to head (550e03a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4018      +/-   ##
==========================================
- Coverage   73.92%   73.91%   -0.01%     
==========================================
  Files         341      341              
  Lines      106510   106520      +10     
==========================================
- Hits        78740    78739       -1     
- Misses      27770    27781      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants