Improve speculative shielded ctx #4019
Open
+375
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sug0
reviewed
Nov 13, 2024
Comment on lines
+943
to
+956
| match namada.submit(tx, &args.tx).await? { | ||
| ProcessTxResponse::Applied(resp) => { | ||
| if let Some(InnerTxResult::Success(_)) = | ||
| resp.batch_result().first().map(|(_, res)| res) | ||
| { | ||
| pre_cache_masp_data(namada, &masp_section).await; | ||
| } | ||
| } | ||
| ProcessTxResponse::Broadcast(_) => { | ||
| pre_cache_masp_data(namada, &masp_section).await; | ||
| } | ||
| // Do not pre-cache when dry-running | ||
| ProcessTxResponse::DryRun(_) => {} | ||
| } |
There was a problem hiding this comment.
this pattern is repeated a couple of times. could be abstracted into a method
Comment on lines
+6162
to
+6164
| // The speculative context invalidates the entire note spent so we expect to | ||
| // see the balance coming only from the second unspent note | ||
| assert!(captured.contains("nam: 100")); |
There was a problem hiding this comment.
I think we should emit a warning in this case, or prefix the token alias (ex: speculative {token}: {amount}). another reason to emit a warning is that by using an older anchor, as @batconjurer pointed out, we could be revealing when a note was first created. in an ideal scenario the user will always call shielded-sync, or we call it automatically again. IMO the only blocker for the latter would be improving the UX of canceling the shielded sync process, which takes a while to return control to the shell after hitting Ctrl+C.
batconjurer
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3457.
Closes #2593.
Moved the transition to the
SpeculativeContextfrom the SDK to the client to have access to the (possible) tx result. The transition is now performed when:The transition is not performed when:
Added an integration test to verify the behavior of the client when in a speculative context.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo