Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wasm_for_tests/ into the wasm workspace #891

Closed
wants to merge 2 commits into from

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Dec 13, 2022

Closes #102

This PR attempts to move our test wasms (wasm_for_tests/wasm_source) into the wasm workspace (wasm/test_wasms). Previously test wasms were prebuilt directly under wasm_for_tests/*.wasm - since wasm/*.wasm globs our production wasms, the test wasms are now built under wasm/test_wasms/built/*.wasm. This is just to get things working, not actually sure where is best to put them.

Low priority, may be better to tidy up references to the wasm_for_tests directory first in our code, as it's referenced in many places.

@james-chf
Copy link
Contributor Author

Moving this works straightforwardly enough but the current wasm_for_tests path is hardcoded/references in disparate places, we should probably clean that up a bit first before doing this move (e.g. as in #893)

@james-chf james-chf closed this Dec 16, 2022
@james-chf james-chf deleted the james/mainline/mv-wasm-for-tests branch December 16, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a Cargo workspace for wasm crates
1 participant