Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error underlining and popup problems #153

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Fix error underlining and popup problems #153

merged 4 commits into from
Nov 11, 2024

Conversation

lukaszcz
Copy link
Contributor

@lukaszcz lukaszcz commented Nov 7, 2024 •
edited
Loading

  • Updates Juvix version to 0.6.8
  • Closes errors are not cleared immediately #152
  • Makes silent typechecking (on change or save) call a task, which solves the problem of underlined errors not updating.
  • Adds the --vscode option to the invocation of the typecheck Juvix command. This makes the extension not compatible with Juvix versions earlier than 0.6.8.

@lukaszcz lukaszcz self-assigned this Nov 7, 2024
@lukaszcz lukaszcz mentioned this pull request Nov 8, 2024
Merged
lukaszcz added a commit to anoma/juvix that referenced this pull request Nov 11, 2024
@lukaszcz
Add --vscode option (#3162)
fc0d5a3 
* Add a `--vscode` option which causes the error messages to be printed
without newlines, in a way compatible with the problem matcher of the
VSCode extension
* Related VSCode extension PR:
anoma/vscode-juvix#153
@paulcadman paulcadman mentioned this pull request Nov 11, 2024
Merged
2 tasks
lukaszcz pushed a commit to anoma/juvix that referenced this pull request Nov 11, 2024
@paulcadman
Release 0.6.8 (#3165)
bebe3d1 
The purpose of this release is to add support for the `--vscode` flag,
required by an update to the juvix vscode extension.

* #3162
* anoma/vscode-juvix#153

This PR updates:

- [x] Package version
- [x] Smoke test

The CHANGELOG generator we use:
https://github.com/github-changelog-generator/github-changelog-generator
has stopped working with errors like the following:

```
Warning: PR 3148 merge commit was not found in the release branch or tagged git history and no rebased SHA comment was found
```

So we'll defer populating the CHANGELOG summary until after the release.
@lukaszcz lukaszcz requested a review from jonaprieto November 11, 2024 17:30
@lukaszcz lukaszcz marked this pull request as ready for review November 11, 2024 17:30
@lukaszcz lukaszcz changed the title Fix problems with the extension Fix error underlining and popup problems Nov 11, 2024
@lukaszcz lukaszcz merged commit 9f8150a into main Nov 11, 2024
17 checks passed
@lukaszcz lukaszcz deleted the fix-extension branch November 11, 2024 17:49
@lukaszcz lukaszcz mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

@jonaprieto jonaprieto Awaiting requested review from jonaprieto

Assignees

@lukaszcz lukaszcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errors are not cleared immediately
2 participants
@lukaszcz @paulcadman