Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary PR that will fail the plugin install test #13

Closed
wants to merge 3 commits into from
Closed

Arbitrary PR that will fail the plugin install test #13

wants to merge 3 commits into from

Conversation

anomiex
Copy link
Owner

@anomiex anomiex commented Jan 9, 2023

Fixes #

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@anomiex
build: Move "Test plugin upgrades" to a post-build workflow
b51b068 
GitHub has an unfortunate behavior in that workflow artifacts are not
available via the API until the entire workflow has completed. This
means that the "Test plugin upgrades" job in the build workflow
unnecessarily delays the availability of the build artifact for Jetpack
Live Branches and future wpcom automated testing for 6 or so minutes.

To get around this, we create a new "Post-Build" workflow that is
triggered by `workflow_run` after the Build workflow completes. But
since this new workflow isn't automatically attached to the PR, we have
to make API calls to get it to show up there.

This is a second attempt at Automattic#25892, which had to be reverted as using
the Actions app put the checks into the "suite" of a random workflow.
@anomiex
Trim workflows
fdbf2a0
@anomiex anomiex mentioned this pull request Jan 9, 2023
Merged
3 tasks
@anomiex anomiex force-pushed the trunk branch 12 times, most recently from 52f7fd0 to 0de0975 Compare May 20, 2023 17:58
@anomiex anomiex force-pushed the trunk branch 2 times, most recently from f3284db to 60a416e Compare August 30, 2023 14:00
@anomiex anomiex force-pushed the trunk branch 10 times, most recently from 5d93525 to 5d7882b Compare January 30, 2024 16:54
@anomiex anomiex force-pushed the trunk branch 2 times, most recently from cebab81 to 9584b75 Compare April 4, 2024 18:07
@anomiex anomiex force-pushed the trunk branch 2 times, most recently from b03e6b5 to a0c3167 Compare April 10, 2024 13:25
@anomiex anomiex closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anomiex