fix: use std::shared_ptr instead of std::unique_ptr for shared ressource, use operator[] instead of find_field #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_field
orfind_field_unordered
. Theoperator[]
is mapped tofind_field_unordered
. Thefind_field
is fine, but it is used when you know the order of the keys, which is more appropriate for private JSON uses.std:: unique_ptr
that gets passed as a pointer. To me, it suggests thatstd:: shared_ptr
is more appropriate.std::string
instances although it is probably not significant.