FreeRTOS_TCP_WIN_utest.c: Fix memory leaks of type free(NULL)

The pointer to the allocated memory was reset. ⏚
anordal · May 26, 2024 · 8fc5a6b · 8fc5a6b
1 parent 818fad0
commit 8fc5a6b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/test/unit-test/FreeRTOS_TCP_WIN/FreeRTOS_TCP_WIN_utest.c b/test/unit-test/FreeRTOS_TCP_WIN/FreeRTOS_TCP_WIN_utest.c
@@ -392,11 +392,14 @@ void test_vTCPSegmentCleanup_segment_null( void )
 void test_vTCPSegmentCleanup_segment_not_null( void )
 {
     /* will be freed by the function under test */
-    xTCPSegments = ( TCPSegment_t * ) malloc( 123 );
+    TCPSegment_t * pxTCPSegment = malloc( sizeof( TCPSegment_t ) );
+
+    xTCPSegments = pxTCPSegment;
 
     vPortFree_Expect( xTCPSegments );
     vTCPSegmentCleanup();
     TEST_ASSERT_NULL( xTCPSegments );
+    free( pxTCPSegment );
 }
 
 void test_lTCPWindowRxCheck_sequence_nums_equal( void )
@@ -1233,7 +1236,9 @@ void test_lTCPWindowTxAdd_lBytesLeft_gt_zero_data_length_gt_maxlen( void )
     int32_t lMax = 0;
 
     /* in real code, this points to a list of segments */
-    xWindow.pxHeadSegment = malloc( sizeof( TCPSegment_t ) );
+    TCPSegment_t * pxTCPSegment = malloc( sizeof( TCPSegment_t ) );
+
+    xWindow.pxHeadSegment = pxTCPSegment;
     xWindow.pxHeadSegment->lMaxLength = 300;
     xWindow.pxHeadSegment->lDataLength = 200;
     xWindow.pxHeadSegment->u.bits.bOutstanding = pdTRUE_UNSIGNED;
@@ -1265,7 +1270,7 @@ void test_lTCPWindowTxAdd_lBytesLeft_gt_zero_data_length_gt_maxlen( void )
 
     TEST_ASSERT_EQUAL( 25, lDone );
     TEST_ASSERT_NULL( xWindow.pxHeadSegment );
-    free( xWindow.pxHeadSegment );
+    free( pxTCPSegment );
 }
 
 void test_lTCPWindowTxAdd_lBytesLeft_gt_zero_data_length_lt_maxlen( void )