Remove show_cavers_on_trip_list setting

anorthall · Dec 19, 2023 · 7033847 · 7033847
1 parent 75ed1d8
commit 7033847
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 212 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ your privacy settings.
 via the info tab. Users can only view their own profile view count.
 - A bug where no 'Add friend' link was shown on smaller screens has been fixed.
 - A bug preventing the photos tab being shown when the user had less than 40 photos has been fixed.
+- The ability to show a list of cavers under each trip on the trip list has been removed.
 
 #### Trip detail page
 - A trip view counter has been added. Users can only view the view count for their own trips. The

diff --git a/app/templates/logger/profile_trips_table.html b/app/templates/logger/profile_trips_table.html
diff --git a/app/users/forms.py b/app/users/forms.py
@@ -288,7 +288,6 @@ class Meta:
             "allow_friend_username",
             "allow_friend_email",
             "allow_comments",
-            "show_cavers_on_trip_list",
             "disable_distance_statistics",
             "disable_survey_statistics",
             "disable_stats_over_time",
@@ -312,7 +311,6 @@ def __init__(self, *args, **kwargs):
                 Div("allow_friend_username", css_class="col"),
                 Div("allow_friend_email", css_class="col"),
                 Div("allow_comments", css_class="col"),
-                Div("show_cavers_on_trip_list", css_class="col"),
                 css_class="row row-cols-1 row-cols-lg-3 mt-4",
             ),
             HTML('<h5 class="mt-3">Statistics</h5>'),

diff --git a/app/users/migrations/0045_remove_cavinguser_show_cavers_on_trip_list.py b/app/users/migrations/0045_remove_cavinguser_show_cavers_on_trip_list.py
@@ -0,0 +1,16 @@
+# Generated by Django 4.2 on 2023-12-19 23:16
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("users", "0044_remove_cavinguser_public_statistics"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="cavinguser",
+            name="show_cavers_on_trip_list",
+        ),
+    ]
diff --git a/app/users/models.py b/app/users/models.py
@@ -286,14 +286,6 @@ class CavingUser(AbstractBaseUser, PermissionsMixin):
             "time chart on the statistics page."
         ),
     )
-    show_cavers_on_trip_list = models.BooleanField(
-        "Show cavers on trip list",
-        default=False,
-        help_text=(
-            "Enabling this option will display a list of cavers "
-            "beneath each trip on your profile trip list."
-        ),
-    )
 
     # Custom fields
     custom_field_1_label = models.CharField(