Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic JavaScript trip list #220

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Add dynamic JavaScript trip list #220

merged 12 commits into from
Dec 19, 2023

Conversation

anorthall
Copy link
Owner

@anorthall anorthall commented Dec 19, 2023

Changes:

  • Use Tabulator to display the trip list on the user profile.
  • Enable searching through trips.
  • Enable expanding trips to view notes.
  • Enable filtering of the trip list.
  • Style the trip list for both light and dark modes of Bootstrap.

@anorthall anorthall added front-end Templates and user experience features New features that should be implemented refactor Refactoring of existing code labels Dec 19, 2023
@anorthall anorthall self-assigned this Dec 19, 2023
@anorthall anorthall marked this pull request as ready for review December 19, 2023 00:20
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request introduces a refactoring of the UserProfile view in the logger app, removing a large chunk of context data setup code and replacing it with a more streamlined approach. It also removes the ProfileTripsTable view and associated URL pattern, suggesting a shift towards a more dynamic client-side rendering of the trip list.

General suggestions:

  • Verify that the removal of the ProfileTripsTable view and its URL pattern aligns with the new dynamic JavaScript trip list implementation and that all functionalities previously provided by the server-side rendered table are now adequately handled by the client-side code.
  • Ensure that the new method get_trips is robust and handles all user cases, including anonymous users, as indicated by the TODO comment.
  • Confirm that the addition of the total_surveyed_dist attribute to the Trip object does not introduce any inconsistencies and is properly reflected across the application.
  • Review the new permission checks and warning messages added to ensure they are consistent with the application's security model and provide a clear user experience.

Your trial expires on December 25, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨

app/logger/views/userprofile.py Show resolved Hide resolved
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dc1b071) 86.57% compared to head (9d09c50) 87.32%.

❗ Current head 9d09c50 differs from pull request most recent head cd6ea23. Consider uploading reports for the commit cd6ea23 to get more accurate results

Files Patch % Lines
app/logger/views/userprofile.py 88.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   86.57%   87.32%   +0.74%     
==========================================
  Files          89       89              
  Lines        4380     4338      -42     
  Branches      575      573       -2     
==========================================
- Hits         3792     3788       -4     
+ Misses        489      452      -37     
+ Partials       99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anorthall anorthall merged commit ffd8e8d into main Dec 19, 2023
4 checks passed
@anorthall anorthall deleted the trip-list branch December 19, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features New features that should be implemented front-end Templates and user experience refactor Refactoring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant