-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic JavaScript trip list #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Refactoring
PR Summary: The pull request introduces a refactoring of the UserProfile view in the logger app, removing a large chunk of context data setup code and replacing it with a more streamlined approach. It also removes the ProfileTripsTable view and associated URL pattern, suggesting a shift towards a more dynamic client-side rendering of the trip list.
General suggestions:
- Verify that the removal of the ProfileTripsTable view and its URL pattern aligns with the new dynamic JavaScript trip list implementation and that all functionalities previously provided by the server-side rendered table are now adequately handled by the client-side code.
- Ensure that the new method
get_trips
is robust and handles all user cases, including anonymous users, as indicated by the TODO comment. - Confirm that the addition of the
total_surveyed_dist
attribute to theTrip
object does not introduce any inconsistencies and is properly reflected across the application. - Review the new permission checks and warning messages added to ensure they are consistent with the application's security model and provide a clear user experience.
Your trial expires on December 25, 2023. Please email tim@sourcery.ai to continue using Sourcery ✨
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 86.57% 87.32% +0.74%
==========================================
Files 89 89
Lines 4380 4338 -42
Branches 575 573 -2
==========================================
- Hits 3792 3788 -4
+ Misses 489 452 -37
+ Partials 99 98 -1 ☔ View full report in Codecov by Sentry. |
Changes: