-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: use git tag / git push instead of http soft tags #210
Conversation
This would be a lot nicer! I think it needs pretty good testing though given it's quite a fundamental change. Any ideas on how we could get confidence in testing it? |
Ill test this in a few repos in the next few weeks from my fork and confirm. |
@sammcj lets merge this hahaha everytime we merge a pr there are problems... look https://github.com/anothrNick/github-tag-action/actions/runs/5248300455/jobs/9479783919 from #272 tests succeded but permissions still dramatic I have no idea whats going on. I assume has to be related to ownership of source branch/repo |
commit code changes make it a flag so is not a breaking change add testing for patch fix id
Change git tag over http to git cli
Fixes: https://github.com/anothrNick/github-tag-action/actions/runs/3372412451/jobs/5595804270#step:4:89
My availability to test this is low.
But is what we use to tag the major tag in here https://github.com/anothrNick/github-tag-action/blob/master/.github/workflows/main.yml#L36-L50
I don't see why not use the same approach everywhere instead of soft tags.
We might need to add more checks to this.