-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Auto Releases #317
Fix Auto Releases #317
Conversation
To clarify this we closed as we only release this repo using self action not third party actions. |
Re-opened as https://github.com/softprops/action-gh-release looks like a better alternative to the archived action we currently use for releases. |
If we merge as is it won't trigger a release because we are not updating the entrypoint or dockerfile etc. I would suggest adding a comment somewhere to force a release at merge. No further comments from me. |
1ee8655
to
5a9c832
Compare
Rebased on master, removed the placeholder comments, and threw in a comment to Let me know if you have any more concerns or questions. |
Approved. Not sure why I cannot merge |
Assuming @anothrNick you changed my permissions? |
I haven't changed your permissions. Maybe because I reopened? Not sure |
Can @gabriel-stackhouse and or @anothrNick merge this. |
@sbe-arg I don't have write permissions to the repo, so I'm also unable to merge. |
Summary of changes
Poking around in this repository, I saw your comment in your main workflow file that auto-release creation was broken. Seeing as I have auto-releases working splendidly for my organization, I figured I'd pass along my config if you were interested in using it.
Feel free to change/tweak/adjust whatever you like here, or to reject it entirely. Completely up to you.
Breaking Changes
NO
How changes have been tested
Ran the workflow on my own forked repo with success:
List any unknowns
N/A