Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize jackson annotations for getters (to disable null values) #160

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

bou3108
Copy link
Collaborator

@bou3108 bou3108 commented Aug 20, 2024

image

@bou3108 bou3108 changed the title patch: reuse health package to update customize jackson annotations for getters (to disable null values) Aug 20, 2024
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 70.22% 🍏

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

File Coverage [76.45%] 🍏
WhatsHappen.java 97.29% 🍏
Rtype.java 96.9% 🍏
WhatsHappen.java 96.22% 🍏
WhatsHappen.java 96.22% 🍏
LocationKind.java 93.9% 🍏
LocationKind.java 93.9% 🍏
Destination.java 93.4% 🍏
Caller.java 92.94% 🍏
Etype.java 92.46% 🍏
Location.java 91.01% 🍏
Caller.java 90.55% 🍏
Location.java 90.13% 🍏
RiskThreat.java 83.9% 🍏
HealthMotive.java 82.51% 🍏
HealthMotive.java 82.51% 🍏
HealthMotive.java 82.51% 🍏
Decision.java 82.15% 🍏
RiskThreat.java 77.57% 🍏
Decision.java 66.99% 🍏
Contact.java 66.17% 🍏
Mission.java 62.77% 🍏
Resource.java 62.68% 🍏
Request.java 62.56% 🍏
ExternalInfo.java 61.41% 🍏
Resource.java 61.22% 🍏
State.java 59.55%
ExternalLocationId.java 59.48%
Resource.java 59.12%
Position.java 55.96%
Event.java 54.98%
Context.java 53.92%
Contact.java 53.88%
Link.java 51.76%
Coord.java 51.63%
Operator.java 46.09%
Sender.java 45.45%
Recipient.java 45.45%
Alert.java 44.62%
ExternalLocationId.java 43.53%
Qualification.java 38.25%
Casualties.java 37.85%
Attachment.java 37.74%
CallTaker.java 37.67%
CustomMap.java 37.57%
Coord.java 37.42%
Geometry.java 37.42%
DetailedAddress.java 37.42%
WayName.java 37.42%
DetailedName.java 37.42%
Reference.java 37.01%
Coord.java 35%
Point.java 34.94%
Coord.java 34.84%
Response.java 33.91%
Patient.java 33.91%
Regulation.java 33.2%
Coord.java 28.53%
Alert.java 14.75%
Intervention.java 12.28%
Event.java 10.65%
ResourceStatus.java 10.51%
MedicalNote.java 10.31%
DetailedName.java 9.68%
WayName.java 9.68%
Orientation.java 9.68%
Team.java 9.68%
Geometry.java 9.09%
Point.java 9.09%
MainDiagnosis.java 9.09%
DetailedAddress.java 9.09%
ResidentialAddress.java 9.09%
Patient.java 8.95%
DetailedAddress.java 7.94%
CustomMap.java 5.82%
ExternalInfo.java 0%
Contact.java 0%
Rgeo.java 0%
OtherDiagnosis.java 0%
ExternalId.java 0%
ExternalInfo.java 0%
Total Project Coverage 70.22% 🍏

Copy link
Collaborator

@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca me semble régler le problème en effet, bien vu !!
Et en gros, pas vraiment d'impact particulier si ?
Ca change pas vraiment les indications dans les IDE mais juste comment c'est sérialisé en JSON ? Et d'ailleurs, comment ça se passe en XML du coup ?
Quelques petites questions,

  • Ca fait quoi NON_EMPTY au niveau du parent exactement ? => ça le met dans le JSON que si pas vide ?
  • Et ça faisait quoi ALWAYS au niveau de la propriété ? => ça le met toujours dans le JSON même si vide ?
  • Et USE_DEFAULTS fait quoi ? => il s'appuie sur la propriété au niveau du parent pour décider ?

@bou3108 bou3108 merged commit e875a9f into develop Aug 20, 2024
1 of 2 checks passed
@bou3108 bou3108 deleted the fix/fix-generated-getters branch August 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants