cli_parse: Fix finding relative template_path when used inside role/collection #333

Mark0016 · 2024-02-13T15:36:48Z

SUMMARY

This allows the cli_parse module to find parser.template_path inside roles or collections when a path relative to the role/collection directory is provided.
This makes behavior consistent with core modules like copy and template when paths are provided this way.

Fixes #332

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cli_parse

ADDITIONAL INFORMATION

See #332 for reproduction of the issue.
I used the same setup to validate that the changes fixed it.
With these changes cli_parse behaves as expected

$ ansible-playbook -v test_playbook.yml
No config file found; using defaults
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit
localhost does not match 'all'

PLAY [Use role with cli_parse template] **************************************************************

TASK [test_role : use custom cli_parse template] *****************************************************
ok: [localhost] => {"changed": false, "parsed": {"data": ["foo", "bar"]}}

PLAY RECAP *******************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

softwarefactory-project-zuul · 2024-02-13T15:57:34Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f080c98be3494db0bf21215b1a020c20

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 7m 26s

softwarefactory-project-zuul · 2024-07-03T13:59:29Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/400fa4b3ed184e0191f5cd3e317b17fd

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 7m 07s

softwarefactory-project-zuul · 2024-07-03T15:17:28Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/17e832a5dcfd4abeb32da5633d67a462

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 6m 50s

This allows parser.template_path to behave as expected inside roles or collections when a path relative to the role/collection directory is provided.

for more information, see https://pre-commit.ci

…tils into cli_parse_find_needle

softwarefactory-project-zuul · 2024-07-05T06:14:27Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a2c3add797844560a824a921f334cb95

✔️ ansible-galaxy-importer SUCCESS in 2m 55s
✔️ build-ansible-collection SUCCESS in 6m 52s

tests/integration/inventory

tests/integration/targets/utils_cli_parse/output/ios_show_version_parsed.json

changelogs/fragments/add_template_path.yaml

for more information, see https://pre-commit.ci

softwarefactory-project-zuul · 2024-07-25T10:45:38Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1a6bb412bf6840cba0ee4ea137390924

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 52s

…tils into cli_parse_find_needle

softwarefactory-project-zuul · 2024-07-25T13:08:24Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2beaeb52ac53428ea7d053a73dee5405

✔️ ansible-galaxy-importer SUCCESS in 3m 40s
✔️ build-ansible-collection SUCCESS in 5m 50s

.github/workflows/tests.yml

softwarefactory-project-zuul · 2024-07-25T15:48:16Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/97d258cafb69414793c79833d7118bad

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 5m 43s

…tils into cli_parse_find_needle

for more information, see https://pre-commit.ci

softwarefactory-project-zuul · 2024-07-25T16:30:28Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/08869f4502a64c02b30870af96d33ee9

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 45s

Mark0016 temporarily deployed to push February 13, 2024 15:36 — with GitHub Actions Inactive

KB-perByte requested review from ashwini-mhatre, KB-perByte and roverflow February 14, 2024 09:46

NilashishC temporarily deployed to push July 3, 2024 13:39 — with GitHub Actions Inactive

NilashishC requested review from Ruchip16 and removed request for ashwini-mhatre July 3, 2024 13:42

NilashishC temporarily deployed to push July 3, 2024 15:06 — with GitHub Actions Inactive

Mark Vasi and others added 2 commits July 4, 2024 16:40

Fix finding relative template_path when provided

d45cd9c

This allows parser.template_path to behave as expected inside roles or collections when a path relative to the role/collection directory is provided.

add tests

b890e3d

Ruchip16 force-pushed the cli_parse_find_needle branch from a26edbd to b890e3d Compare July 5, 2024 05:55

Ruchip16 temporarily deployed to push July 5, 2024 05:55 — with GitHub Actions Inactive

[pre-commit.ci] auto fixes from pre-commit.com hooks

345d223

for more information, see https://pre-commit.ci

pre-commit-ci bot temporarily deployed to push July 5, 2024 05:55 Inactive

Ruchip16 added 2 commits July 5, 2024 11:32

update tests

0203550

Merge branch 'cli_parse_find_needle' of github.com:Mark0016/ansible.u…

9fb1679

…tils into cli_parse_find_needle

Ruchip16 temporarily deployed to push July 5, 2024 06:03 — with GitHub Actions Inactive

NilashishC reviewed Jul 5, 2024

View reviewed changes

tests/integration/inventory Outdated Show resolved Hide resolved

NilashishC requested changes Jul 5, 2024

View reviewed changes

tests/integration/targets/utils_cli_parse/output/ios_show_version_parsed.json Outdated Show resolved Hide resolved

changelogs/fragments/add_template_path.yaml Show resolved Hide resolved

Ruchip16 marked this pull request as draft July 5, 2024 08:44

add working tests

1af3ac8

Ruchip16 temporarily deployed to push July 25, 2024 09:36 — with GitHub Actions Inactive

[pre-commit.ci] auto fixes from pre-commit.com hooks

fd340f1

for more information, see https://pre-commit.ci

pre-commit-ci bot temporarily deployed to push July 25, 2024 09:37 Inactive

Ruchip16 marked this pull request as ready for review July 25, 2024 09:37

Merge branch 'main' into cli_parse_find_needle

c5e75b7

Ruchip16 had a problem deploying to push July 25, 2024 10:26 — with GitHub Actions Error

[pre-commit.ci] auto fixes from pre-commit.com hooks

3e5a675

for more information, see https://pre-commit.ci

Ruchip16 requested a review from NilashishC July 25, 2024 10:26

pre-commit-ci bot temporarily deployed to push July 25, 2024 10:26 Inactive

Ruchip16 added 2 commits July 25, 2024 18:27

add netcommon dependency

7c1eb9d

Merge branch 'cli_parse_find_needle' of github.com:Mark0016/ansible.u…

19709a9

…tils into cli_parse_find_needle

Ruchip16 temporarily deployed to push July 25, 2024 12:58 — with GitHub Actions Inactive

NilashishC reviewed Jul 25, 2024

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

NilashishC reviewed Jul 25, 2024

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

changes

4a363d4

Ruchip16 temporarily deployed to push July 25, 2024 15:36 — with GitHub Actions Inactive

Ruchip16 requested a review from NilashishC July 25, 2024 15:37

Merge branch 'main' into cli_parse_find_needle

aa4ce7e

Ruchip16 temporarily deployed to push July 25, 2024 15:37 — with GitHub Actions Inactive

Ruchip16 removed request for KB-perByte and roverflow July 25, 2024 15:37

Ruchip16 added 2 commits July 25, 2024 21:30

delete tests as CI is failing

3ac1771

Merge branch 'cli_parse_find_needle' of github.com:Mark0016/ansible.u…

2ead080

…tils into cli_parse_find_needle

Ruchip16 temporarily deployed to push July 25, 2024 16:00 — with GitHub Actions Inactive

changes

18162be

Ruchip16 temporarily deployed to push July 25, 2024 16:03 — with GitHub Actions Inactive

[pre-commit.ci] auto fixes from pre-commit.com hooks

792f2e5

for more information, see https://pre-commit.ci

pre-commit-ci bot temporarily deployed to push July 25, 2024 16:03 Inactive

Ruchip16 approved these changes Jul 25, 2024

View reviewed changes

NilashishC approved these changes Jul 25, 2024

View reviewed changes

Ruchip16 merged commit 8cba2c3 into ansible-collections:main Jul 25, 2024
49 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli_parse: Fix finding relative template_path when used inside role/collection #333

cli_parse: Fix finding relative template_path when used inside role/collection #333

Mark0016 commented Feb 13, 2024

softwarefactory-project-zuul bot commented Feb 13, 2024

softwarefactory-project-zuul bot commented Jul 3, 2024

softwarefactory-project-zuul bot commented Jul 3, 2024

softwarefactory-project-zuul bot commented Jul 5, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

cli_parse: Fix finding relative template_path when used inside role/collection #333

cli_parse: Fix finding relative template_path when used inside role/collection #333

Conversation

Mark0016 commented Feb 13, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Feb 13, 2024

softwarefactory-project-zuul bot commented Jul 3, 2024

softwarefactory-project-zuul bot commented Jul 3, 2024

softwarefactory-project-zuul bot commented Jul 5, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024

softwarefactory-project-zuul bot commented Jul 25, 2024