Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to apply ACL to Junctions #423

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Add support to apply ACL to Junctions #423

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0091ab6
Add support to apply ACL to Junctions
gillg Oct 7, 2022
6de8b6e
Update win_acl.ps1
gillg Oct 7, 2022
9a4be5c
Fix a breaking condition
gillg Oct 7, 2022
3e1b076
Fix lint
gillg Oct 7, 2022
92c6d03
Fix lint
gillg Oct 9, 2022
81d2892
Fix broken script if we use registry paths
gillg Oct 9, 2022
71ab803
Add parameter follow
gillg Nov 1, 2022
55566b3
Add changelog
gillg Nov 1, 2022
7539f51
Fix lint
gillg Nov 1, 2022
cfe6446
Change default and fix up minor things
jborean93 Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions plugins/modules/win_acl.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ $state = Get-AnsibleParam -obj $params -name "state" -type "str" -default "prese

$inherit = Get-AnsibleParam -obj $params -name "inherit" -type "str"
$propagation = Get-AnsibleParam -obj $params -name "propagation" -type "str" -default "None" -validateset "InheritOnly", "None", "NoPropagateInherit"
$follow_links = $True
gillg marked this conversation as resolved.
Show resolved Hide resolved

# We mount the HKCR, HKU, and HKCC registry hives so PS can access them.
# Network paths have no qualifiers so we use -EA SilentlyContinue to ignore that
Expand All @@ -103,6 +104,14 @@ if ($path_qualifier -eq "HKCC:" -and (-not (Test-Path -LiteralPath HKCC:\))) {
New-PSDrive -Name HKCC -PSProvider Registry -Root HKEY_CURRENT_CONFIG > $null
}

$path = Resolve-Path -LiteralPath $path
Do {
$PathDetails = Get-ItemProperty -LiteralPath $path
if ($PathDetails.Target -and $PathDetails.Target.GetType().Name -eq "String[]" -and $follow_links) {
jborean93 marked this conversation as resolved.
Show resolved Hide resolved
$path = "\\?\$($PathDetails.Target.Get(0))"
}
} While ($PathDetails.LinkType)

If (-Not (Test-Path -LiteralPath $path)) {
Fail-Json -obj $result -message "$path file or directory does not exist on the host"
}
Expand Down Expand Up @@ -191,10 +200,10 @@ Try {
If ($state -eq "present" -And $match -eq $false) {
Try {
$objACL.AddAccessRule($objACE)
If ($path_item.PSProvider.Name -eq "Registry") {
Try {
Set-ACL -LiteralPath $path -AclObject $objACL
}
else {
Catch {
(Get-Item -LiteralPath $path).SetAccessControl($objACL)
}
$result.changed = $true
Expand Down