Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to force reimport a cert if you added a private key with win_certificate_store #424

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

gillg
Copy link
Contributor

@gillg gillg commented Oct 7, 2022

SUMMARY

If you try to import a cert in the cert store wich already exists but without a private key associated, you can't because Ansible will detect no change at thumbprint level.
With that change ansible will force reimport if a private key is present during the second import.

We could imagine also force the import, if at the opposite, we remove the private key later. To be discussed.

…tificate_store

If you try to import a cert in the cert store wich already exists but without a private key associated, you can't because Ansible will detect no change at thumbprint level.
Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in the review here. I've been travelling for AnsibleFest and recently had to take some time off after.

plugins/modules/win_certificate_store.ps1 Show resolved Hide resolved
@jborean93 jborean93 merged commit 38fd057 into ansible-collections:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants