Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security_profile options to azure_rm_virtualmachine #1033

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add security_profile options to azure_rm_virtualmachine #1033

merged 4 commits into from
Feb 13, 2023

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Add security_profile options to azure_rm_virtualmachine, try to fixes #1006, #1031

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_virtualmachine.py
azure_rm_virtualmachine_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority and removed ready_for_review The PR has been modified and can be reviewed and merged labels Nov 29, 2022
This was referenced Nov 29, 2022
Closed
Closed
@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Feb 8, 2023
@dgiesselbach
Copy link

Please review this pullrequest. We have been waiting for this for 4 months :)

rmeichsner
rmeichsner approved these changes Feb 9, 2023
View reviewed changes
Copy link

@rmeichsner rmeichsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dgiesselbach
dgiesselbach approved these changes Feb 10, 2023
View reviewed changes
Copy link

@dgiesselbach dgiesselbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fine

@xuzhang3 xuzhang3 merged commit c889f64 into ansible-collections:dev Feb 13, 2023
@Fred-sun Fred-sun deleted the Add_security_profile_to_vm branch February 23, 2023 07:36
Klaas- added a commit to Klaas-/azure that referenced this pull request Jun 30, 2023
@Klaas-
Refs ansible-collections#1033 fix security profile for virtualimachin…
3343f33 
…e_info
xuzhang3 pushed a commit that referenced this pull request Jul 7, 2023
@Klaas- @Fred-sun
Refs #1033 fix security profile for azure_rm_virtualmachine_info (#1205)
76f4efd 
* Refs #1033 fix security profile for virtualimachine_info

* Update plugins/modules/azure_rm_virtualmachine_info.py

Fix indentation

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update plugins/modules/azure_rm_virtualmachine_info.py

Fix indentation

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

---------

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhang3 xuzhang3 xuzhang3 approved these changes

@dgiesselbach dgiesselbach dgiesselbach approved these changes

@rmeichsner rmeichsner rmeichsner approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Create Azure VM with TrustedLaunch, vTPM and secure boot?
4 participants
@Fred-sun @dgiesselbach @rmeichsner @xuzhang3