Keyvault Lookup Plugin Added

[taasest8]

SUMMARY

Moving azure_keyvault_secret lookup plugin from old role repo to this collection.
Using code suggested from taarpa6 that also does a check on the http status code before further processing. This fixes a (time-out) issue when not using an Azure managed identity and not running from an Azure VM.

Old PR (closed but never merged): Azure/azure_preview_modules#349

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

azure_keyvault_secret lookup plugin

ADDITIONAL INFORMATION

To use a lookup plugin the full namespace needs to be referenced.

- name: lookup secrets
          set_fact:
            secret_var: "{{ lookup('azure.azcollection.azure_keyvault_secret','secret-name', vault_url=az_vault_uri, client_id=az_vault_client_id, secret=az_vault_secret, tenant_id=az_vault_tenant) }}"

[Fred-sun]

@haiyuazhang Could you please help take a review this issue? Thank you very much!

[uda]

Hi @taasest8, this is great and solves many issues in automation.

Can this be modified to leverage generic Azure CLI auth as well? not just MSI or in-code SP credentials.

[weemel]

Hello, I guess this is no longer valid as the azure module is now deprecated - are there any plans to update the plugin with azure-identity and merge it? I'd be happy to help as this would be useful for templating :)

[Ompragash]

Hello, I guess this is no longer valid as the azure module is now deprecated - are there any plans to update the plugin with azure-identity and merge it? I'd be happy to help as this would be useful for templating :)

@Fred-sun Could you confirm?

[Fred-sun]

@Ompragash Yes, It will be useful. I will review with developer and push for merge! thank you very much!

[taasest8]

Hello @Fred-sun, did the minor changes, what rights do you need on the pr ? afaik you should have enough rights as you are the owner of the base repository.

[guillaumewatteeux]

@taasest8 could you add an option to bypass MSI token ?

[Fred-sun]

trailing whitespace

[Fred-sun]

Complete all test exceptions to avoid security test failures due to requests not being imported!

[Fred-sun]

delete duplicate line!

[Fred-sun]

@taasest8 Thank you for your update. I will complete the inspection and promote the merger as soon as possible. Thank you very much!

[Fred-sun]

@taasest8 One last change!

[Fred-sun]

ready_for_review

[xuzhang3]

LGTM