Add vm_agent_version to output of azure_rm_virtualmachine_info #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
enhancement
|
kingdly ping! |
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
done -- thanks for the review @Fred-sun |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Nov 14, 2023
|
@klaas LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Also return vm_agent_version in azure_rm_virtualmachine_info
This is only returned by API for turned on VMs, so if it's undefined also return "Unknown". "Unknown" + powered on VM means something is wrong with the agent inside the VM.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine_info