Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azurefirewall info returns #1308

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update azurefirewall info returns #1308

merged 2 commits into from
Nov 1, 2023

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Update azurefirewall info returns，fixed an issue where the return value was empty, try to fixes #1302

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_azurefirewall_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun mentioned this pull request Oct 31, 2023
Closed
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority enhancement New feature or request labels Oct 31, 2023
@xuzhang3 xuzhang3 merged commit c5dedcd into ansible-collections:dev Nov 1, 2023
@Fred-sun Fred-sun deleted the update-azurefirewall-info-returns branch November 2, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuzhang3 xuzhang3 xuzhang3 approved these changes

@ephracis ephracis ephracis approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_azurefirewall_info fails with KeyError: 'natRuleCollections'\n in simple configuration
3 participants
@Fred-sun @ephracis @xuzhang3