Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure_rm_accesstoken_info module #1318

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

puiterwijk
Copy link
Contributor

This adds a module to retrieve an access token for Azure.

SUMMARY

This adds a new module to retrieve an Azure access token.
These tokens might be useful for other tasks, for example as a bearer token when pulling DevOps repositories.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_access_token

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 6, 2023

@puiterwijk Please keep same with the other module file naming format, rename to "azure_rm_accesstoken_info.py"

tests/integration/targets/azure_rm_access_token/aliases Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token.py Outdated Show resolved Hide resolved
@Fred-sun Fred-sun added new_module_pr Add new modules medium_priority Medium priority work in In trying to solve, or in working with contributors labels Nov 6, 2023
@puiterwijk puiterwijk force-pushed the add_token_module branch 2 times, most recently from d54a252 to a5a9931 Compare November 12, 2023 13:07
@puiterwijk puiterwijk changed the title Add azure_rm_access_token module Add azure_rm_access_token_info module Nov 12, 2023
@puiterwijk
Copy link
Contributor Author

@Fred-sun thanks for the review! I think I fixed your comments.

Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@puiterwijk Please keep same with the other module file naming format, rename to "azure_rm_accesstoken_info.py"

plugins/modules/azure_rm_access_token_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_access_token_info.py Outdated Show resolved Hide resolved
@puiterwijk puiterwijk changed the title Add azure_rm_access_token_info module Add azure_rm_accesstoken_info module Nov 13, 2023
This adds a module to retrieve an access token for Azure.
@puiterwijk
Copy link
Contributor Author

@Fred-sun sorry about misreading your suggested name the first time! I fixed that and your other remarks.

@Fred-sun
Copy link
Collaborator

ready_for_review

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Nov 13, 2023
@xuzhang3 xuzhang3 merged commit 26aae60 into ansible-collections:dev Nov 21, 2023
@puiterwijk puiterwijk deleted the add_token_module branch November 21, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_module_pr Add new modules ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants