Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parameters to azure_rm_aksagentpool.py #1477

Merged

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Mar 5, 2024

SUMMARY

Add more parameters to azure_rm_aksagentpool.py, try to fixes #1445

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_aksagentpool.py
azure_rm_aksagentpool_info.py

ADDITIONAL INFORMATION

description:
- Sysctl setting fs.file-max.
type: int
fs_aio_max_nr:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is what I was looking for!

Copy link

@aaron-armada aaron-armada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Mar 6, 2024
@xuzhang3 xuzhang3 merged commit 3342a8e into ansible-collections:dev May 22, 2024
@Fred-sun Fred-sun deleted the Add-parameters-to-agentpool branch May 24, 2024 02:38
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
…1477)

* Add more parameters to azure_rm_aksagentpool.py

* Modify test case

* small change for test

* Modify test case

* last change

* small change for test

* new change

* Add just test order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to create AKS Agent Nodepool with custom configuration file
3 participants