allow service principals and nested groups to be returned in membership attributes #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugins/modules/azure_rm_adgroup.py
kent007
changed the title
Fred-sun
reviewed
Mar 22, 2024
Fred-sun
added
question
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
May 21, 2024
Justwmz
pushed a commit
to Justwmz/azure
that referenced
this pull request
Nov 4, 2024
…ip attributes (ansible-collections#1507) * commit WIP group stuff * Fix: group returns * remove errant parameter * clean up docs * fix doc * remove underscore * Apply suggestions from code review Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> --------- Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1506
ISSUE TYPE
COMPONENT NAME
azure_rm_adgroup
azure_rm_adgroup_info
ADDITIONAL INFORMATION
I also fixed a few typos in docs and function names. Verified with some manual testing and a clean pass of ansible sanity tests