Fix for inventory host processing #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
reviewed
May 5, 2024
| @@ -602,7 +602,8 @@ def hostvars(self): | |||
| # set nic-related values from the primary NIC first | |||
| for nic in sorted(self.nics, key=lambda n: n.is_primary, reverse=True): | |||
| # and from the primary IP config per NIC first | |||
| for ipc in sorted(nic._nic_model['properties']['ipConfigurations'], key=lambda i: i['properties'].get('primary', False), reverse=True): | |||
| for ipc in sorted(nic._nic_model.get('properties', {}).get('ipConfigurations', []), | |||
There was a problem hiding this comment.
@p3ck continuation line under-indented
for ipc in sorted(nic._nic_model.get('properties', {}).get('ipConfigurations', []),
key=lambda i: i.get('properties', {}).get('primary', False), reverse=True)
There was a problem hiding this comment.
fixed - Thank for the review
This change provides sane defaults when NIC's are still in process of coming up.
Fred-sun
added
ready_for_review
|
ready_for_review! |
xuzhang3
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change provides sane defaults when NIC's are still in process of coming up.
Fixes #1544
ISSUE TYPE
COMPONENT NAME
plugins/inventory/azure_rm.py
ADDITIONAL INFORMATION
See the issue for the traceback that this fixes
I've had the customer that experienced this traceback use this patch and it fixes the issue.