Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-cli-core to 2.61.0 #1593

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jun 10, 2024

SUMMARY

In particular, this change unpins packaging version in newer versions as the azure-cli-core==2.34.0 does has a ceiling that prevents used of modern versions. Versions after 2.61.0 have removed this bug. Note that listing packaging as a direct dependency without any constraints does not help in any way, as resolver will still attempt to downgrade packaging if old version of azure-cli-core is requested.

Fixes: #1474

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dependencies

ADDITIONAL INFORMATION

See: Azure/azure-cli@97effd7
See: Azure/azure-cli#18548
See: https://issues.redhat.com/browse/AAP-19993
See: https://issues.redhat.com/browse/ACA-1651

@ssbarnea ssbarnea marked this pull request as ready for review June 10, 2024 14:45
@Fred-sun
Copy link
Collaborator

@ssbarnea Why is it necessary to remove these dependency packages and specify the currently used version, thank you!

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jun 11, 2024
@tima
Copy link

tima commented Jun 11, 2024

@Fred-sun: @ssbarnea found that we cannot update black for ansible-lint because it requires a newer version of the packaging. The azure collection does not allow use of newer one due to its own pinning of an outdated version of azure-cli-core. So when we create build where both are present, the two come into conflict.

@ssbarnea ssbarnea changed the title Unpin dependencies Update azure-cli-core to 2.61.0 Jun 11, 2024
@ssbarnea
Copy link
Member Author

ssbarnea commented Jun 11, 2024

@Fred-sun I updated only azure-cli-core to 2.61.0 but I am not sure if this file is valid because:

  • There is testing framework setup inside the repo for validation requirements (like tox or nox)
  • I do not see any pipelines running on CI on the PR
  • Attempt to install the requirements on M1 macos (aarch64) and on Fedora 40 ended up failing to compile uamqp dependency. Still installing just azure-cli-core==2.61.0 succeeds, this means that one of the other ~50 pinned dependencies is not ok.

Looking in the log files, it seems that uamqp comes from:

Collecting uamqp<2.0.0,>=1.2.14 (from azure-iot-hub==2.6.1->-r requirements.txt (line 47))
  Downloading uamqp-1.6.9.tar.gz (4.5 MB)

Apperently this issue is caused by another known bug #1505 <- https://issues.redhat.com/browse/ACA-1652

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 13, 2024
@p3ck
Copy link
Collaborator

p3ck commented Jun 17, 2024

I updated my dev environment to 2.61.0 and ran a few of the integation tests with no issues. I can do additional testing if needed.

@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit c8cd084 into ansible-collections:dev Jun 18, 2024
@p3ck
Copy link
Collaborator

p3ck commented Jun 18, 2024

Ok , so when I tested this I used an already deployed instance and just upgraded the azure-cli-core and I didn't get any errors.

But I have since done a new deployment and I get the following errors...

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
azure-cli 2.61.0 requires azure-mgmt-apimanagement==4.0.0, but you have azure-mgmt-apimanagement 3.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-authorization~=4.0.0, but you have azure-mgmt-authorization 2.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-batch~=17.3.0, but you have azure-mgmt-batch 16.2.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-cdn==12.0.0, but you have azure-mgmt-cdn 11.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-compute~=31.0.0, but you have azure-mgmt-compute 30.6.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-containerinstance==10.1.0, but you have azure-mgmt-containerinstance 9.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-containerregistry==10.3.0, but you have azure-mgmt-containerregistry 9.1.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-containerservice~=30.0.0, but you have azure-mgmt-containerservice 20.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-cosmosdb==9.4.0, but you have azure-mgmt-cosmosdb 6.4.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-devtestlabs~=4.0, but you have azure-mgmt-devtestlabs 9.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-iothub==3.0.0, but you have azure-mgmt-iothub 2.2.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-keyvault==10.3.0, but you have azure-mgmt-keyvault 10.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-loganalytics==13.0.0b4, but you have azure-mgmt-loganalytics 12.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-managedservices~=1.0, but you have azure-mgmt-managedservices 6.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-monitor~=5.0.0, but you have azure-mgmt-monitor 3.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-rdbms~=10.2.0b16, but you have azure-mgmt-rdbms 10.2.0b12 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-recoveryservices~=3.0.0, but you have azure-mgmt-recoveryservices 2.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-recoveryservicesbackup~=9.1.0, but you have azure-mgmt-recoveryservicesbackup 3.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-redis~=14.3.0, but you have azure-mgmt-redis 13.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-resource==23.1.1, but you have azure-mgmt-resource 21.1.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-search~=9.0, but you have azure-mgmt-search 8.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-servicebus~=8.2.0, but you have azure-mgmt-servicebus 7.1.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-sql==4.0.0b16, but you have azure-mgmt-sql 3.0.1 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-storage==21.1.0, but you have azure-mgmt-storage 19.0.0 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-trafficmanager~=1.0.0, but you have azure-mgmt-trafficmanager 1.0.0b1 which is incompatible.
azure-cli 2.61.0 requires azure-mgmt-web==7.2.0, but you have azure-mgmt-web 6.1.0 which is incompatible.
azure-mgmt-datalake-nspkg 3.0.1 requires azure-mgmt-nspkg>=3.0.0, but you have azure-mgmt-nspkg 2.0.0 which is incompatible.

I think this needs to be reverted until we verify all these versions.

p3ck added a commit that referenced this pull request Jun 18, 2024
xuzhang3 pushed a commit that referenced this pull request Jun 19, 2024
p3ck pushed a commit to p3ck/ansible-collections_azure that referenced this pull request Jun 20, 2024
xuzhang3 pushed a commit that referenced this pull request Jun 24, 2024
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority question Further information is requested ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinned azure-cli-core has associated vulnerabilities
5 participants