-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure-cli-core to 2.61.0 #1593
Conversation
@ssbarnea Why is it necessary to remove these dependency packages and specify the currently used version, thank you! |
@Fred-sun: @ssbarnea found that we cannot update black for ansible-lint because it requires a newer version of the packaging. The azure collection does not allow use of newer one due to its own pinning of an outdated version of azure-cli-core. So when we create build where both are present, the two come into conflict. |
@Fred-sun I updated only azure-cli-core to 2.61.0 but I am not sure if this file is valid because:
Looking in the log files, it seems that uamqp comes from:
Apperently this issue is caused by another known bug #1505 <- https://issues.redhat.com/browse/ACA-1652 |
I updated my dev environment to 2.61.0 and ran a few of the integation tests with no issues. I can do additional testing if needed. |
LGTM |
Ok , so when I tested this I used an already deployed instance and just upgraded the azure-cli-core and I didn't get any errors. But I have since done a new deployment and I get the following errors...
I think this needs to be reverted until we verify all these versions. |
…ollections#1608) Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
SUMMARY
In particular, this change unpins
packaging
version in newer versions as theazure-cli-core==2.34.0
does has a ceiling that prevents used of modern versions. Versions after2.61.0
have removed this bug. Note that listingpackaging
as a direct dependency without any constraints does not help in any way, as resolver will still attempt to downgrade packaging if old version ofazure-cli-core
is requested.Fixes: #1474
ISSUE TYPE
COMPONENT NAME
dependencies
ADDITIONAL INFORMATION
See: Azure/azure-cli@97effd7
See: Azure/azure-cli#18548
See: https://issues.redhat.com/browse/AAP-19993
See: https://issues.redhat.com/browse/ACA-1651