Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support python 3.8 #246

Merged
merged 5 commits into from
Sep 9, 2020

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Sep 3, 2020

SUMMARY

Update requirement file. Try to fixes #139

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_mariadbserver

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Sep 3, 2020
@UnwashedMeme
Copy link
Contributor

azure-cli-core==2.11.1 requires (amongst others)

  • azure-mgmt-resource==10.2.0
  • msrestazure>=0.6.3

but the requirements-azure.txt after this change has

  • azure-mgmt-resource==2.1.0
  • msrestazure==0.6.2

Presumably those requirements were increased in the azure-cli-core for a reason, but even if not this causes problems for tools like pipenv or others that implement dependency resolvers.

@uda
Copy link

uda commented Sep 6, 2020

This change helped me run it on python 3.8.5, but what @UnwashedMeme wrote...

I won't say to remove them from requirements-azure.txt since they are used directly in code, but perhaps use open or loose version specification.

@Fred-sun
Copy link
Collaborator Author

Fred-sun commented Sep 8, 2020

azure-cli-core==2.11.1 requires (amongst others)

  • azure-mgmt-resource==10.2.0
  • msrestazure>=0.6.3

but the requirements-azure.txt after this change has

  • azure-mgmt-resource==2.1.0
  • msrestazure==0.6.2

Presumably those requirements were increased in the azure-cli-core for a reason, but even if not this causes problems for tools like pipenv or others that implement dependency resolvers.

@UnwashedMeme Thanks for your feedback! I have update azure-mgmt-resource version!

@Fred-sun Fred-sun force-pushed the update_azure_cli_core branch from a63ff00 to 5dcb188 Compare September 8, 2020 09:43
@UnwashedMeme
Copy link
Contributor

@Fred-sun please don't forget msrestazure needs updating as well.

Is there any work to upgrade all of the azure libraries to more recent/latest version? Do this more systematically?

@Fred-sun
Copy link
Collaborator Author

Fred-sun commented Sep 8, 2020

@Fred-sun please don't forget msrestazure needs updating as well.

Is there any work to upgrade all of the azure libraries to more recent/latest version? Do this more systematically?

This cannot be done, because some package updates will cause the api return value to be different, which requires testing before updating. Thank you!

@haiyuazhang haiyuazhang merged commit 8248c87 into ansible-collections:dev Sep 9, 2020
@Fred-sun Fred-sun deleted the update_azure_cli_core branch September 10, 2020 02:23
@haiyuazhang haiyuazhang changed the title Update requirement file support python 3.8 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection fails with python 3.8
4 participants