resolve issue (#268) #307
Merged
resolve issue (#268) #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
|
ready_for_review |
Fred-sun
reviewed
Nov 6, 2020
Fred-sun
added
work in
|
kindly ping |
|
@uDuCkV Can I make some updates to your PR? This would recommend merging PR. Thank you very much! |
|
Yes of course @Fred-sun. Please be my guest. |
Thanks for your reply, Every is OK! I will push for merged! |
Fred-sun
added
ready_for_review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There was a spelling in default conditions regarding api_server_profile parameters, which led to ignore completely api_server_profile parameters.
ISSUE TYPE
COMPONENT NAME
azure_rm_openshiftmanagedcluster
ADDITIONAL INFORMATION