Add new module to deploy Azure Cognitive Search 'azure_rm_cognitivesearch'

[next-davidduquehernandez]

SUMMARY

This module allows to deploy, update and delete an Azure Cognitive Search.

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

• azure_rm_search
• azure_rm_search_info

ADDITIONAL INFORMATION

All dev info could be found at https://docs.microsoft.com/en-us/rest/api/searchservice/

[Fred-sun]

@next-davidduquehernandez Please add module name "azure_rm_search.py" to pr-pipeline.yml. Thank you very much!

[Fred-sun]

@next-davidduquehernandez Please help to adjust your test case --main.yml, thank you!

[Fred-sun]

@next-davidduquehernandez Please fixes follow sanity error! Thank you very much!

ERROR: plugins/modules/azure_rm_search.py:0:0: nonexistent-parameter-documented: Argument 'append_tags' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'hosting_mode' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'identity' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'location' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'partition_count' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'public_network_access' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'replica_count' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'sku' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type

[next-davidduquehernandez]

@next-davidduquehernandez Please fixes follow sanity error! Thank you very much!

ERROR: plugins/modules/azure_rm_search.py:0:0: nonexistent-parameter-documented: Argument 'append_tags' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'hosting_mode' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'identity' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'location' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'partition_count' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'public_network_access' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'replica_count' in argument_spec defines type as 'int' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'resource_group' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'sku' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_search.py:0:0: parameter-type-not-in-doc: Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type

Hi @Fred-sun,

I'm so sorry, sometimes I forgot to follow all steps before commit and push my code :S.

I've verifyed that there is no sanity error message and integration tests are launched and finished correctly.

Regards!

[Fred-sun]

@next-davidduquehernandez Thank you for your contribution, please help to fix the plugins/module_utils/azure_rm_common.py file conflict! Thank you very much!

[next-davidduquehernandez]

@Fred-sun Merge realized, sanity and integration tests passed correctly after merge. Regards

[Fred-sun]

@next-davidduquehernandez Please add this line "plugins/modules/azure_rm_search.py validate-modules:nonexistent-parameter-documented" to "tests/sanity/ignore-2.9.txt". Thanks!

[Fred-sun]

@next-davidduquehernandez Can you change the "sku:standard3" in the test case to "sku:standard" for convenient test automation? Thank you very much!

[Fred-sun]

Please

[next-davidduquehernandez]

@next-davidduquehernandez Can you change the "sku:standard3" in the test case to "sku:standard" for convenient test automation? Thank you very much!

Hi @Fred-sun, accourding to documentation, hosting_mode "highDensity" only accepts sku "standard3". You decide what to do.

https://docs.microsoft.com/en-us/rest/api/searchmanagement/services/createorupdate

Applicable only for the standard3 SKU. You can set this property to enable up to 3 high density partitions that allow up to 1000 indexes, which is much higher than the maximum indexes allowed for any other SKU. For the standard3 SKU, the value is either 'default' or 'highDensity'. For all other SKUs, this value must be 'default'.

Regards!

[Fred-sun]

@next-davidduquehernandez Yes, I want you to change it to "sku: standard; hosting_mode: default". Thank you!

[Fred-sun]

@next-davidduquehernandez All change is OK, Please make last change, modify module name "azure_rm_search*" to "azure_rm_cognitivesearch", Thank you very much!

[next-davidduquehernandez]

Hi @Fred-sun, Modified test in order to change sku to 'standard' and hosting_mode to 'default' and rename module from 'azure_rm_search*' to 'azure_rm_cognitivesearch*'.

Regards

[Fred-sun]

@next-davidduquehernandez Please help to resolve the conflict file! I will push for merge! Thank you very much!

[next-davidduquehernandez]

Hi @Fred-sun,

I think that update from @haiyuazhang resolves the conflict.

Regards!

[Fred-sun]

@next-davidduquehernandez Thanks for you update! I will push for merged!

[Ompragash]

@Fred-sun Could you kindly take a look at it?

[Fred-sun]

@Fred-sun Could you kindly take a look at it?

@Ompragash This PR has been changed and is waiting to be merged. Thank you very much!