Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: azure_rm_ipgroup #528

Merged
merged 12 commits into from
May 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2021

SUMMARY

This module supports following operations for IP Group resource -

  1. Create new IP Group
  2. Update an existing IP group
  3. Delete IP group
  4. Get details about specific IP Group
  5. List all IP groups by resource group or subscription
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_ipgroup
azure_rm_ipgroup_info

ADDITIONAL INFORMATION
https://docs.microsoft.com/en-us/rest/api/virtualnetwork/ipgroups

@Fred-sun Fred-sun added medium_priority Medium priority new_module_pr Add new modules work in In trying to solve, or in working with contributors labels May 12, 2021
@haiyuazhang haiyuazhang force-pushed the dev branch 2 times, most recently from 2281f46 to 8dfc8ed Compare May 12, 2021 11:26
@haiyuazhang haiyuazhang changed the title Add azure_rm_ipgroup module New module: azure_rm_ipgroup May 17, 2021
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techcon65 It will better to add check mode test for "azure/tests/integration/targets/azure_rm_ipgroup/tasks/main.yml"

- name: Create IP group (check mode)
  azure_rm_ipgroup:
    resource_group: "{{ resource_group }}"
    name: "{{ group_name }}"
    location: eastus
    ip_addresses:
      - 13.64.39.16/32
      - 40.74.146.80/31
      - 40.74.147.32/28
    tags:
      key1: "value1"
    state: present
  check_mode: yes

plugins/modules/azure_rm_ipgroup_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_ipgroup_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_ipgroup.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_ipgroup.py Outdated Show resolved Hide resolved
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 27, 2021
@ghost
Copy link
Author

ghost commented May 27, 2021

@techcon65 It will better to add check mode test for "azure/tests/integration/targets/azure_rm_ipgroup/tasks/main.yml"

- name: Create IP group (check mode)
  azure_rm_ipgroup:
    resource_group: "{{ resource_group }}"
    name: "{{ group_name }}"
    location: eastus
    ip_addresses:
      - 13.64.39.16/32
      - 40.74.146.80/31
      - 40.74.147.32/28
    tags:
      key1: "value1"
    state: present
  check_mode: yes

Sure @Fred-sun Added check_mode test as suggested and tested it locally! Working as expected. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_module_pr Add new modules ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants