Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue identifying a creation/deletion error #542

Merged

Conversation

matburt
Copy link
Contributor

@matburt matburt commented May 13, 2021

SUMMARY

OpenShiftManagedCluster creation bails out at the first self.fail which shows the body but doesn't show the actual exception. Deletion doesn't even raise an error and passes through silently

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_openshiftmanagedcluster

ADDITIONAL INFORMATION

Before this change the only error you would see:

msg: |-                                                                         
Error creating the OpenShiftManagedCluster instance: {...post data...}

With this change it gets more helpful

msg: |-                                                                         
Error creating the OpenShiftManagedCluster instance: {...post data...}
Azure Error: InvalidParameter
Message: The provided pull secret is invalid.
Target: properties.clusterProfile.pullSecret 

OpenShiftManagedCluster creation bails out at the first self.fail which shows the body but doesn't show the actual exception. Deletion doesn't even raise an error and passes through silently
@haiyuazhang haiyuazhang merged commit 53b7da5 into ansible-collections:dev May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants