Addition of Spot instance support for VM and VMSS #559
Conversation
|
@ElPrincidente Thanks for your contribution! Would you add test case to tests/integration/targets/azure_rm_virmachine*/, It will help to merge this PR! |
Fred-sun
added
medium_priority
@Fred-sun I've incorporated that text markup suggested. Right now I have a few roadblock running integration test with my MSDN Azure Subscription (obsolete SKU, unavailable image size, etc). Will commit the new integration test as soon as possible. |
|
@ElPrincidente Can these two newly added parameters be updated? If it is possible to update, please help to add the update logic judgment. If not, please indicate that it is not possible to update as in line 1091 and 1092. Thank you very much! |
|
@Fred-sun added update logic to fail if any of the spot parameters (priority, eviction_policy, max_price) are changed. Integration test were also update to test spot VM/VMSS. I had to change the VMSS integration test image since CoreOs has reached EOL and image were removed from Azure. The only outstanding item is the "eviction_policy" default value, see my comment above |
|
@ElPrincidente Could you please help to authorize me to update this PR? Thank you very much! |
@Fred-sun you should be able to modify this PR. I've push the latest change (removing the default value + whitespace formatting comment from above) Thank you ! |
|
@ElPrincidente Thank you. I will help complete this PR. |
@ElPrincidente I'm sorry, but I still don't have your authorization. Thank you very much! |
@Fred-sun I apologize for the confusion, first time collaborating on GH (more used to my company's GHE flow). I've added you as a collaborator to my fork, please advise me if there anything else I need to do in order to authorize you for modifying this PR. |
…zure into vm_spot_instance
Fred-sun
added
ready_for_review
@ElPrincidente It‘s OK, I will move forward with the merger as soon as possible. Thank you very much! |
…s#559) * Addition of Spot instance support for VM and VMSS * PR comment relative to formatting * Addition of spot instance test for azure_rm_virtualmachine and vmss * Changed default priority to None. Added validation for Spot param update * Removed default values for spot instances parameters + formatting * small change Co-authored-by: Vincent Prince <vincent.prince@cae.com> Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> Co-authored-by: Fred-sun <xiuxi.sun@qq.com>
SUMMARY
Fixes #397
Addition of Spot VM instance for both azure_rm_virtualmachine and azure_rm_virtualmachinescaleset by adding a priority field. Azure python SDK was already supporting the feature.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine
azure_rm_virtualmachinescaleset
ADDITIONAL INFORMATION
By default Azure API will create a "Regular" VM if priority is not set. If priority is set to "Spot", it will look at eviction_policy and max_price to setup the spot instance.