enable_floating_ip is for SQL AlwaysOn not SNAT #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
documentation-pr
craigminihan
force-pushed
the
correct-enable_floating_ip-description
branch
from
ceca8f7 to
e8e1345
Compare
craigminihan
force-pushed
the
correct-enable_floating_ip-description
branch
from
e8e1345 to
b800a19
Compare
|
LGTM |
Fred-sun
pushed a commit
to Fred-sun/ansible_collections_azure
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
enable_floating_ipis documented in the module source as an SNAT setting however it is for SQL AlwaysOn. This text has ended up ondocs.ansible.comand does not describe the behaviour of the setting.ISSUE TYPE
COMPONENT NAME
azure_rm_loadbalancer
ADDITIONAL INFORMATION
The
enable_floating_ipsetting is described here: https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.network.models.loadbalancingrule.enablefloatingip?view=azure-dotnetHowever text from
DisableOutboundSnat(an unsupported setting) has somehow made it into the description field for the module.I'd like to add support for the Snat setting so correcting this doc entry before proceeding with that change.