Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres server backup-support #566

Merged
merged 20 commits into from
Aug 6, 2021

Conversation

karisN
Copy link
Contributor

@karisN karisN commented Jun 14, 2021

add support for backup redundancy options

SUMMARY

Postgres server has backup redundancy options, which can only be set during the creation. These parameters are missing from the plugin today.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_postgresqlserver

ADDITIONAL INFORMATION

Add:
geo redundant backup flag
backup retention days
creation modes (default, point in time restore, geo redundant restore)

add support for backup redundancy options
@karisN karisN changed the title backup-support postgres server backup-support Jun 14, 2021
@Fred-sun Fred-sun added medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Jun 15, 2021
@Fred-sun
Copy link
Collaborator

@karisN Would you help to add test case for these paramter (source_server_id and restore_point_in_time) . Thank you very much!

@karisN
Copy link
Contributor Author

karisN commented Jun 18, 2021

@karisN Would you help to add test case for these paramter (source_server_id and restore_point_in_time) . Thank you very much!

I'm not actually familiar with how the tests are setup in this project, but AFAIK geo backup occurs only twice a day. It's not likely a backup will become available for restore immediately in a test case, additionally I don't have info on when point_in_time restore is available after creation either. What are my options for restore test cases?

Karis Ng and others added 5 commits June 17, 2021 21:14
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
karisN and others added 2 commits June 21, 2021 17:49
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karisN Please delete 252 line. the file " tests/sanity/ignore-2.10.txt". You have resolved.
plugins/modules/azure_rm_postgresqlserver.py validate-modules:parameter-type-not-in-doc

plugins/modules/azure_rm_postgresqlserver.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_postgresqlserver.py Outdated Show resolved Hide resolved
@Fred-sun
Copy link
Collaborator

@karisN Could you please help to authorize me to update this PR? Thank you very much!

karisN and others added 6 commits June 22, 2021 09:58
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 23, 2021
@dpodder
Copy link

dpodder commented Jul 21, 2021

Hi @Fred-sun and team, is there anything holding up this PR? We were looking for similar requirements in another project and this would fill the exact missing functionality we'd need.

@Fred-sun
Copy link
Collaborator

@dpodder We plan to merge this PR next week, and I will push forward the solution. Thank you very much!

- point_in_time_restore
source_server_id:
description:
- Id if the source server if I(create_mode=default).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karisN There is something wrong with this description statement. Please refer to the relevant documents of this module and describe it again. Thank you very much!

@xuzhang3 xuzhang3 merged commit 7844203 into ansible-collections:dev Aug 6, 2021
Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
* backup-support

add support for backup redundancy options

* fix indentation, added more docs

* update docs

* update docs

* Update doc

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update doc

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update doc

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* Update doc

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* PR comments

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* PR comments

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* PR comments, remove parameter-type-not-in-doc validation

* remove parameter-type-not-in-doc validation

* remove parameter-list-no-elements validate

* fix sanity fail

Co-authored-by: Karis Ng <kng@pros.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <xiuxi.sun@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants