-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgres server backup-support #566
postgres server backup-support #566
Conversation
add support for backup redundancy options
@karisN Would you help to add test case for these paramter (source_server_id and restore_point_in_time) . Thank you very much! |
I'm not actually familiar with how the tests are setup in this project, but AFAIK geo backup occurs only twice a day. It's not likely a backup will become available for restore immediately in a test case, additionally I don't have info on when point_in_time restore is available after creation either. What are my options for restore test cases? |
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karisN Please delete 252 line. the file " tests/sanity/ignore-2.10.txt". You have resolved.
plugins/modules/azure_rm_postgresqlserver.py validate-modules:parameter-type-not-in-doc
@karisN Could you please help to authorize me to update this PR? Thank you very much! |
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Hi @Fred-sun and team, is there anything holding up this PR? We were looking for similar requirements in another project and this would fill the exact missing functionality we'd need. |
@dpodder We plan to merge this PR next week, and I will push forward the solution. Thank you very much! |
- point_in_time_restore | ||
source_server_id: | ||
description: | ||
- Id if the source server if I(create_mode=default). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karisN There is something wrong with this description statement. Please refer to the relevant documents of this module and describe it again. Thank you very much!
* backup-support add support for backup redundancy options * fix indentation, added more docs * update docs * update docs * Update doc Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * Update doc Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * Update doc Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * Update doc Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * PR comments Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * PR comments Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> * PR comments, remove parameter-type-not-in-doc validation * remove parameter-type-not-in-doc validation * remove parameter-list-no-elements validate * fix sanity fail Co-authored-by: Karis Ng <kng@pros.com> Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com> Co-authored-by: Fred-sun <xiuxi.sun@qq.com>
add support for backup redundancy options
SUMMARY
Postgres server has backup redundancy options, which can only be set during the creation. These parameters are missing from the plugin today.
ISSUE TYPE
COMPONENT NAME
azure_rm_postgresqlserver
ADDITIONAL INFORMATION
Add:
geo redundant backup flag
backup retention days
creation modes (default, point in time restore, geo redundant restore)