Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing notes for dev/testing #574

Merged
merged 6 commits into from
Aug 5, 2021
Merged

Update contributing notes for dev/testing #574

merged 6 commits into from
Aug 5, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Jul 3, 2021 •
edited
Loading

SUMMARY

This PR updates documentation for how people can contribute (development/testing). Fixes #476.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

doc

@l3ender l3ender mentioned this pull request Jul 3, 2021
Closed
@l3ender l3ender marked this pull request as ready for review July 4, 2021 21:36
@l3ender
Copy link
Contributor Author

l3ender commented Jul 4, 2021

@Fred-sun Please review...thanks!

/cc @paultaiton

paultaiton
paultaiton reviewed Jul 4, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@paultaiton
Copy link
Contributor

@l3ender

Looks good. I added a couple "suggestions" that are really questions I have and not specific suggestions. If you don't know the answers we can also wait for @Fred-sun to chime in.

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jul 5, 2021

@l3ender @paultaiton I'm reviewing it! Thank you very much!

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jul 5, 2021

@l3ender

Looks good. I added a couple "suggestions" that are really questions I have and not specific suggestions. If you don't know the answers we can also wait for @Fred-sun to chime in.

I think a permanent link is preferable, so that no matter how the document is updated, it can be accessed directly. Thank you very much!

@Fred-sun Fred-sun added documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Jul 5, 2021
@l3ender
Copy link
Contributor Author

l3ender commented Jul 20, 2021

Hi @Fred-sun, any update on this PR?

@Fred-sun
Copy link
Collaborator

Fred-sun commented Aug 2, 2021

Hi @Fred-sun, any update on this PR?

@l3ender Merger will be promoted in the near future. Thank you very much!

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Aug 5, 2021

LGTM, ship it

@xuzhang3 xuzhang3 merged commit ffe8498 into ansible-collections:dev Aug 5, 2021
@l3ender l3ender deleted the contributing-guide branch August 6, 2021 15:41
Fred-sun pushed a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
@l3ender @Fred-sun
Update contributing notes for dev/testing (ansible-collections#574)
f7aeca4 
* update contributing notes for dev/testing

* update contributing/testing doc with env setup

* clarify credential permission for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultaiton paultaiton paultaiton left review comments

Assignees
No one assigned
Labels
documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need for expanded guide for contributing.
4 participants
@l3ender @paultaiton @Fred-sun @xuzhang3