Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return value for azure_rm_containerregistry idempotent test #578

Merged

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Jul 8, 2021

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_containerregistry.py
azure_rm_containerregistry_info.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged enhancement New feature or request labels Jul 8, 2021
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jul 9, 2021

LGTM

@xuzhang3 xuzhang3 merged commit 07ab56a into ansible-collections:dev Jul 9, 2021
Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this pull request Aug 11, 2021
* add new paramter node_labels for agent_pool

* remove space

Add return value for azure_rm_containerregistry idempotent test (ansible-collections#578)

* Add return value for azure_rm_containerregistry idempotent test

* fix sanity error:

* remove require set

azure_rm_roleassignment bugfix (ansible-collections#464)

* pushing fixes.

* whitespace

* whitespace

* Update aliases

* add assignee filter to triplet lookup

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

azure_rm_aks: support system-assigned (managed) identity, (ansible-collections#514)

* azure_rm_aks: make linux_profile and service_principal optional, support system-assigned (managed) identity

* azure_rm_aks: adjust docs formatting

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

* azure_rm_aks: add a test for the minimal parameters cluster definition

* azure_rm_aks: fix sanity-checks / pep8 requirements

* Add instructions for tests / sanity checks

Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>

Upddate test case (ansible-collections#585)
@Fred-sun Fred-sun deleted the update_for_containerregistry branch December 31, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants