azure_rm_virtualmachine: suppress no_log warning on ssh_password_enabled parameter #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
enhancement
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
azure_rm_virtualmachine is issuing a warning about ssh_password_enabled not being set to
no_log=true. This patch explicitly sets no_log tofalsefor this benign parameter.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
The warning being displayed by the module prior to this patch:
ssh_password_enabledis only a boolean and does not contain secret information or credentials. Ansible's heuristics are assuming wrong.