Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed disk ID to returned facts for data disks for azure_rm_virtualmachine_info #682

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Nov 12, 2021

SUMMARY

As mentionned in #679 (comment), azure_rm_virtualmachine_info does not give the disk ID for attached disks.
This PR adds the disk ID to the data_disk list returned by azure_rm_virtualmachine_info

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_virtualmachine_info

@Fred-sun
Copy link
Collaborator

@nbr23 Thanks for your contribute, I will review and push for merge!

@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Nov 12, 2021
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Dec 8, 2021

LGTM

@xuzhang3 xuzhang3 merged commit 505caa4 into ansible-collections:dev Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants