Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters for webapp site config #695

Merged
merged 5 commits into from
Nov 23, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Nov 21, 2021

SUMMARY

This PR updates the azure_rm_webapp module to support the following parameters:

  • always_on: Keeps the app loaded even when there's no traffic.
  • min_tls_version: The minimum TLS encryption version required for the app.
  • ftps_state: The state of the FTP/FTPS service.

This PR also has a small change which fixes #421.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_webapp
azure_rm_webapp_info

ADDITIONAL INFORMATION

Please see updated test case for detail and validation.

@l3ender
Copy link
Contributor Author

l3ender commented Nov 21, 2021

@Fred-sun Another PR--thank you! ;)

@Fred-sun
Copy link
Collaborator

@Fred-sun Another PR--thank you! ;)

@l3ender Okay, we'll move forward with the merger as soon as possible. Thank you for your contribution!

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors new_feature New feature requirments labels Nov 22, 2021
@Fred-sun
Copy link
Collaborator

@l3ender Any updates on the comments above? Thank you very much!

@l3ender
Copy link
Contributor Author

l3ender commented Nov 23, 2021

Hi @Fred-sun, I don't see any comments. Can you let me know what you'd like me to do?

Thanks!

@Fred-sun
Copy link
Collaborator

@l3ender The client_affinity_enabled parameter is a bool and the default value is True. You are advised not to change this parameter. Thank you very much!

line 702:
            if self.client_affinity_enabled is not None:
          rebase  to ---  if self.client_affinity_enabled:

@l3ender
Copy link
Contributor Author

l3ender commented Nov 23, 2021

The client_affinity_enabled parameter is a bool and the default value is True.

The change on line 702 of the azure_rm_webapp.py file is actually a bugfix where client_affinity_enabled is not correctly configured when module input parameter is false. There is an issue logged for it at #421.

I noticed the same issue with client_affinity_enabled incorrect behavior when adding the new parameters in this PR, so I went ahead and fixed it. My apologies for combining the changes into a single PR and for not providing any detail on the reason for that change. I hope it is okay!!

Thank you!

l3ender and others added 2 commits November 22, 2021 21:28
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun
Copy link
Collaborator

@l3ender Thanks for you contribute!

@l3ender
Copy link
Contributor Author

l3ender commented Nov 23, 2021

Thank you for the review and suggestions. I have updated and please let me know if there is anything else.

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Nov 23, 2021
@xuzhang3
Copy link
Collaborator

LGTM, shipping it.

@xuzhang3 xuzhang3 merged commit 5abf77f into ansible-collections:dev Nov 23, 2021
@xuzhang3 xuzhang3 deleted the webapp-site-config branch November 23, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_webapp: Client affinity is not disabled
3 participants