-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional parameters for webapp site config #695
Conversation
@Fred-sun Another PR--thank you! ;) |
@l3ender Any updates on the comments above? Thank you very much! |
Hi @Fred-sun, I don't see any comments. Can you let me know what you'd like me to do? Thanks! |
@l3ender The client_affinity_enabled parameter is a bool and the default value is True. You are advised not to change this parameter. Thank you very much!
|
The change on line 702 of the azure_rm_webapp.py file is actually a bugfix where I noticed the same issue with Thank you! |
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@l3ender Thanks for you contribute! |
Thank you for the review and suggestions. I have updated and please let me know if there is anything else. |
LGTM, shipping it. |
SUMMARY
This PR updates the
azure_rm_webapp
module to support the following parameters:always_on
: Keeps the app loaded even when there's no traffic.min_tls_version
: The minimum TLS encryption version required for the app.ftps_state
: The state of the FTP/FTPS service.This PR also has a small change which fixes #421.
ISSUE TYPE
COMPONENT NAME
azure_rm_webapp
azure_rm_webapp_info
ADDITIONAL INFORMATION
Please see updated test case for detail and validation.